Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update param documents #35152

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jul 31, 2024

See: #35161

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 31, 2024
Copy link
Contributor

mergify bot commented Jul 31, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jul 31, 2024
tedxu added 2 commits July 31, 2024 19:52
@tedxu tedxu force-pushed the enhance/update_param_docs branch from 6b50daf to 7d5fa31 Compare July 31, 2024 11:54
@mergify mergify bot added the ci-passed label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (6695c6d) to head (7d5fa31).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35152      +/-   ##
==========================================
+ Coverage   81.03%   81.05%   +0.02%     
==========================================
  Files        1189     1189              
  Lines      143490   143548      +58     
==========================================
+ Hits       116271   116360      +89     
+ Misses      22798    22773      -25     
+ Partials     4421     4415       -6     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.57% <100.00%> (+0.01%) ⬆️
pkg/util/paramtable/grpc_param.go 81.90% <100.00%> (+0.05%) ⬆️
pkg/util/paramtable/quota_param.go 74.83% <100.00%> (+0.06%) ⬆️
pkg/util/paramtable/service_param.go 98.29% <100.00%> (+0.07%) ⬆️

... and 19 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Aug 1, 2024
@sre-ci-robot sre-ci-robot merged commit b4d0f4d into milvus-io:master Aug 1, 2024
15 checks passed
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
See: milvus-io#35161

---------

Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
tedxu added a commit to tedxu/milvus that referenced this pull request Aug 13, 2024
tedxu added a commit to tedxu/milvus that referenced this pull request Aug 13, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants